fix(xlsx): keep integer rendering when a blank cell promotes a column to float - #2485
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Conversation
A single blank cell makes pandas read a numeric column as float64, so every whole number in it rendered as "1.0" even though Excel shows "1". Columns whose present values are all whole numbers are converted back to integers before the HTML render; fractional columns, missing cells and non-float columns are unchanged. Applies to both the .xlsx and .xls converters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2484.
After reading each sheet, integral float columns (every non-null value is integral) are rewritten to object-dtype ints before
to_html, so whole numbers keep their integer rendering even when a blank cell promoted the column to float64. Applied to both the .xlsx and .xls paths.New tests cover the mixed blank/int column for both formats (fail on main with
1.0/2.0, pass here) plus float-column preservation cases; suite otherwise unchanged (891 passed, same 5 pre-existing env failures as main).