Add tests for PlainTextConverter - #2479
Open
daere1 wants to merge 1 commit into
Open
Conversation
PlainTextConverter (packages/markitdown/src/markitdown/converters/_plain_text_converter.py) had no dedicated unit tests. Add coverage for: - accepted file extensions (.txt, .text, .md, .markdown, .json, .jsonl) - accepted mimetype prefixes (text/, application/json, application/markdown) - accepts() short-circuiting to True whenever stream_info.charset is set - decoding via a declared charset vs. charset_normalizer auto-detection Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
daere1 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlainTextConverter(packages/markitdown/src/markitdown/converters/_plain_text_converter.py) had no dedicated unit tests. This adds coverage for:.txt,.text,.md,.markdown,.json,.jsonl)text/,application/json,application/markdown)accepts()short-circuiting toTruewheneverstream_info.charsetis set, regardless of extension/mimetypecharset_normalizerauto-detection when no charset is declaredTesting
python -m pytest packages/markitdown/tests/test_plain_text_converter.py -v— 12 passedpython -m pytest packages/markitdown/tests -q— 900 passed, 5 skipped, 13 pre-existing failures unrelated to this change (Windows console-encoding issues intest_cli_vectors.pysubprocess tests, and atest_speech_transcriptionfailure from a missingffprobe/network dependency in this environment)This is my first contribution to this project 🙂
🤖 Generated with Claude Code