Preserve whitespace underlines - #2477
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation is covered across direct HTML, standard DOCX, and OCR conversion paths.
Pull request overview
Preserves whitespace-only underlined content during HTML and DOCX conversion.
Changes:
- Bypasses underline trimming for whitespace-only text.
- Adds HTML, DOCX, and OCR regression coverage.
File summaries
| File | Description |
|---|---|
packages/markitdown/src/markitdown/converters/_markdownify.py |
Preserves whitespace-only underline contents. |
packages/markitdown/tests/test_html_converter.py |
Tests HTML underline whitespace handling. |
packages/markitdown/tests/test_module_misc.py |
Tests DOCX whitespace-only underlined runs. |
packages/markitdown-ocr/tests/test_docx_converter.py |
Tests equivalent OCR converter behavior. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The OCR line-break test has an inconsistent expected value that will fail.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
afourney
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.