Throw an error when llm client fails with image converter. - #2476
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation matches the documented behavior and has comprehensive regression coverage.
Pull request overview
Removes overly broad image-caption error suppression so MarkItDown can attempt fallback converters or report conversion failure.
Changes:
- Propagates LLM client errors from
ImageConverter. - Documents OpenAI retry configuration and failure behavior.
- Tests propagation, fallback conversion, and unchanged success paths.
File summaries
| File | Description |
|---|---|
README.md |
Documents retries and exhausted-error handling. |
packages/markitdown/src/markitdown/converters/_image_converter.py |
Stops suppressing LLM client exceptions. |
packages/markitdown/tests/test_image_converter.py |
Covers failure, fallback, success, and no-LLM behavior. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverses #1948 -- an overly-broad try/catch was the wrong solution here.
In this PR, the README is updated to explain how to adjust the automatic retry behavior of the OpenAI client, and how MarkItDown handles errors in cases where all retries fail.