Fix ANSI Outlook MSG decoding for Japanese code pages and padded strings - #2462
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation is focused, fallback behavior is preserved, and the new edge cases are well tested.
Pull request overview
Improves legacy ANSI Outlook MSG conversion for padded strings and Japanese code pages.
Changes:
- Removes trailing NUL padding before decoding.
- Adds CP50221/50222 Katakana and SO/SI decoding.
- Adds regression coverage for padding, Japanese text, and fallbacks.
File summaries
| File | Description |
|---|---|
packages/markitdown/src/markitdown/converters/_outlook_msg_converter.py |
Implements ANSI cleanup and Japanese decoding. |
packages/markitdown/tests/test_outlook_msg_ansi.py |
Adds comprehensive regression tests. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Flourney I emailed you a few days ago from s.chalkley94@gmail.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve ANSI .msg conversion by removing trailing NUL padding and correctly decoding Japanese code pages 50220–50222.
Changes