Conversation
Fix numa parsing in job exporter on GB200.
Fix kubespray deployment on bare metal when cffi package is installed by package manager.
Co-authored-by: Rui Gao <ruigao@microsoft.com>
Co-authored-by: Rui Gao <ruigao@microsoft.com> Co-authored-by: zhogu <57975490+zhogu@users.noreply.github.com>
* change trigger of github workflow * update * update * update
Co-authored-by: Rui Gao <ruigao@microsoft.com>
There was a problem hiding this comment.
Pull request overview
Release PR to merge v1.5 fixes into dev, focusing on stability/circular-dependency resolution, deployment reliability, and job-exporter NUMA parsing correctness.
Changes:
- Break circular dependencies in rest-server by switching several imports to lazy
require()calls. - Fix NUMA parsing in job-exporter’s node exporter by skipping incomplete
numactl --hardwareCPU lines. - Update kubespray deployment scripts/requirements and adjust GitHub Actions workflow triggers for release/build pipelines.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/rest-server/src/utils/manager/user/crudK8sSecret.js | Lazy-load job model to avoid circular dependency during user VC history retrieval. |
| src/rest-server/src/models/v2/storage.js | Lazy-load user model in list/get to avoid circular dependency. |
| src/rest-server/src/models/v2/job/k8s.js | Lazy-load user model in put to avoid circular dependency. |
| src/job-exporter/src/Moneo/src/worker/exporters/node_exporter.py | Improve NUMA CPU list parsing to avoid parsing empty cpus: lines. |
| docs/LuciaTrainingPlatform/blog/2026-02-06-release-1-5.md | Add v1.5.0 release notes blog post. |
| contrib/kubespray/script/requirements.txt | Add cffi pin for kubespray scripting environment. |
| contrib/kubespray/script/environment.sh | Remove python3-cffi alongside python3-cryptography to avoid pip/apt conflicts. |
| .github/workflows/build-deploy-changes.yaml | Remove push trigger; workflow now runs on PRs targeting main/dev/release/*. |
| .github/workflows/build-all.yaml | Adjust PR trigger types, default dispatch branch, and job gating condition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zhogu
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merge bug fixes from v1.5 to dev branch.
Major Revisions