Skip to content

Fix type-related build failures in sqlite package#208

Draft
Copilot wants to merge 4 commits intomainfrom
copilot/fix-type-related-build-failures
Draft

Fix type-related build failures in sqlite package#208
Copilot wants to merge 4 commits intomainfrom
copilot/fix-type-related-build-failures

Conversation

Copy link

Copilot AI commented Mar 12, 2026

vscode-languageserver-protocol was imported in the sqlite package but never declared as a dependency.

Changes

  • sqlite/package.json

    • Add vscode-languageserver-types: ^3.17.5 as an explicit dependency
    • Update @types/node to 22.19.15
    • Engine requirement set to >=22
  • sqlite/src/compress.ts, sqlite/src/blobStore.ts

    • Replace import * as lsp from 'vscode-languageserver-protocol' with vscode-languageserver-types — all consumed types (Range, Diagnostic, FoldingRange, DocumentSymbol, Hover, MarkupContent, MarkedString) are available in the lighter types-only package, which is already a transitive dependency via lsif-protocol
  • package.json

    • Update @types/node to 22.19.15
  • protocol/package.json, language-service/package.json

    • Set engine requirement to >=22
  • build/azure-pipelines/linux/build.yml, build/azure-pipelines/win32/build.yml, build/azure-pipelines/lsif-repository-tests.yml

    • Update Node.js version to 22.22.0 to align with VS Code
  • build/azure-pipelines/pipeline.yml

    • Update all test platform Node.js versions to 22.22.0

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits March 12, 2026 16:47
Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
@rzhao271
Copy link

@copilot Downgrade all workflows to Node 22 to align with VS Code, and resolve any new typing issues that show up.

Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Copy link
Author

Copilot AI commented Mar 12, 2026

@copilot Downgrade all workflows to Node 22 to align with VS Code, and resolve any new typing issues that show up.

Done in 371ce36. Updated all pipeline/workflow files to Node 22 (20.14.0/14.16.022.14.0, 20.9.022.9.0), updated @types/node to 22.9.0, updated engine requirements to >=22.9.0, and reverted better-sqlite3 back to ^10.1.0 (the Node 24 V8 issue doesn't apply to Node 22). No new typing issues appeared — the build compiles cleanly and all 64 tests pass.

Copilot AI requested a review from rzhao271 March 12, 2026 17:16
@rzhao271
Copy link

@copilot minor versions aren't consistent. Use 22.22.0 on all workflows. Engine requirement should just be 22

Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Copy link
Author

Copilot AI commented Mar 12, 2026

@copilot minor versions aren't consistent. Use 22.22.0 on all workflows. Engine requirement should just be 22

Done in 3d592a4. All workflow files now use 22.22.0 consistently, and engine requirements have been simplified to >=22. Note that @types/node is pinned at 22.19.15 (the latest available v22 release of that package, since @types/node versioning doesn't match Node.js releases exactly).

@rzhao271 rzhao271 added this to the On Deck milestone Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants