Fix sandcastle golden test failures by enabling markdown fenced-code-attributes extension - #133
Merged
Merged
Conversation
Co-authored-by: teqdruid <1498080+teqdruid@users.noreply.github.com>
Co-authored-by: teqdruid <1498080+teqdruid@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job build-linux / build
Fix sandcastle golden test failures by enabling markdown fenced-code-attributes extension
Aug 20, 2026
John Demme (teqdruid)
marked this pull request as ready for review
August 20, 2026 23:59
John Demme (teqdruid)
approved these changes
Aug 20, 2026
Todd (toddmass)
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build-linuxCI job was failing: sandcastle's internal golden markdown tests (examples,decls) no longer matched their golden files because generated fenced code blocks lost theirkanagawalanguage annotation.Root cause
styleCodeBlocks(tools/sandcastle/lib/Sandcastle/DocGen.hs) correctly tags code blocks with thekanagawaclass in the Pandoc AST.writePandocintools/sandcastle/lib/Sandcastle.hs) enabledExt_backtick_code_blocksbut notExt_fenced_code_attributes— the extension pandoc requires to actually emit fence info-string attributes (class/language) on output. Without it, the class is silently dropped during rendering even though it's present in the AST.Fix
Ext_fenced_code_attributesalongside the other writer extensions inwritePandoc:Repo hygiene
dist-newstyletotools/sandcastle/.gitignoreand removed build artifacts that were accidentally committed while reproducing the failure locally.