[WIP] Update to Node 22

[ecraig12345]

Overview

Test Notes

In general, the fix is to stop passing a fully constructed command string into cp.exec/cp.execSync when that string depends on environment or filesystem values, and instead call a no-shell API (cp.spawn / cp.execFile / cp.spawnSync) with the executable and arguments passed separately as an array.

For this codebase, the best targeted fix is:

• Change the generic exec helper in packages/just-scripts/src/utils/exec.ts to accept a cmd and args array, and implement it using cp.spawn rather than cp.exec. This avoids the shell entirely.
• Update its TypeScript type signature accordingly, and keep the promise-based API and stdout/stderr piping behavior unchanged.
• Update the call sites in tslintTask.ts and tscTask.ts that currently build a single cmd string via encodeArgs(...).join(' ') to instead:
  • Build an argument array [process.execPath, tslintCmd, ...args] or [process.execPath, ...args].
  • Call the new exec as exec(process.execPath, args, ...) without using encodeArgs or joining into a string.
  • Keep logging behavior; they can still log encodeArgs([...]).join(' ') for display only.
• Leave encodeArgs implemented as-is for logging or any other callers that may still want shell-style strings; just don’t use it to build the command that is actually executed in these tasks.

Concretely:

• In packages/just-scripts/src/utils/exec.ts, modify exec to:

  export function exec(
    cmd: string,
    args: ReadonlyArray<string> = [],
    opts: cp.SpawnOptions & { stdout?: NodeJS.WritableStream; stderr?: NodeJS.WritableStream } = {},
  ): Promise<string | undefined> {
    // implement using cp.spawn, buffer stdout/stderr when not piped, etc.
  }

  and replace the current cp.exec-based implementation with a cp.spawn-based one that:

  • Pipes child.stdout/child.stderr into the provided streams when present.
  • Otherwise, collects them into buffers/strings so the promise can resolve with the stdout string or reject with an ExecError containing stdout and stderr.
  • Honors opts for cwd, env, etc. (forward them to cp.spawn).

• In tslintTask.ts:

  • Replace const cmd = encodeArgs([process.execPath, tslintCmd, ...args]).join(' '); with separate cmdArgs = [tslintCmd, ...args];.
  • Keep logger.info logging a shell-like representation for humans: logger.info(encodeArgs([process.execPath, tslintCmd, ...args]).join(' '));.
  • Call return exec(process.execPath, [tslintCmd, ...args], { stdout: process.stdout, stderr: process.stderr });.

• In tscTask.ts:

  • For tscTask, keep args = argsFromOptions(tscCmd, options); as-is but:
    • Log with encodeArgs([process.execPath, ...args]).join(' ');.
    • Call return exec(process.execPath, args);.
  • tscWatchTask already uses spawn(process.execPath, cmd, ...) with an argument array, which is safe, so no change is required there.

No new helper methods or imports are required beyond reusing the existing cp.spawn import and the already-exported spawn helper; we only adjust types and logic within the shown snippets.