Sync the grub cmdline changes before exiting#24
Merged
pavanrachapudy90 merged 3 commits intomicrosoft:mainfrom Jan 28, 2026
Merged
Sync the grub cmdline changes before exiting#24pavanrachapudy90 merged 3 commits intomicrosoft:mainfrom
pavanrachapudy90 merged 3 commits intomicrosoft:mainfrom
Conversation
Contributor
shradhagupta6
commented
Jan 21, 2026
…s not ensure that these changes are fully committed to disk. On some filesystems, committing can take tens or even hundreds of seconds. If a hibernation request occurs before the commit completes, the subsequent resume fails because the resume and resume_offset parameters are missing from the kernel command line. To prevent this, the changes to the GRUB cmdline must be explicitly committed to disk. This requires: 1. sync() to flush data buffers, and 2. fsfreeze/unfreeze to flush filesystem metadata and ensure the journal is clean.
pavanrachapudy90
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.