Skip to content

Sync the grub cmdline changes before exiting#24

Merged
pavanrachapudy90 merged 3 commits intomicrosoft:mainfrom
shradhagupta6:shradha_journal_fs_fix
Jan 28, 2026
Merged

Sync the grub cmdline changes before exiting#24
pavanrachapudy90 merged 3 commits intomicrosoft:mainfrom
shradhagupta6:shradha_journal_fs_fix

Conversation

@shradhagupta6
Copy link
Copy Markdown
Contributor

After updating GRUB configuration to enable hibernation, the tool does not ensure that these changes
are fully committed to disk. On some filesystems, committing can take tens or even hundreds of seconds.
If a hibernation request occurs before the commit completes, the subsequent resume fails because the
resume and resume_offset parameters are missing from the kernel command line.

To prevent this, the changes to the GRUB cmdline must be explicitly committed to disk. This requires:

1. sync() to flush data buffers, and

2. fsfreeze/unfreeze to flush filesystem metadata and ensure the journal is clean.

root and others added 3 commits November 5, 2025 06:28
…s not ensure that these changes

are fully committed to disk. On some filesystems, committing can take tens or even hundreds of seconds.
If a hibernation request occurs before the commit completes, the subsequent resume fails because the
resume and resume_offset parameters are missing from the kernel command line.

To prevent this, the changes to the GRUB cmdline must be explicitly committed to disk. This requires:

1. sync() to flush data buffers, and

2. fsfreeze/unfreeze to flush filesystem metadata and ensure the journal is clean.
@pavanrachapudy90 pavanrachapudy90 merged commit 34dfeda into microsoft:main Jan 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants