Repository navigation
fix(docs): add Spokane video previews and new-tab links - #260
Merged
Merged
Conversation
Add episode-specific JPEG posters while preserving caption tracks and lazy playback. Open published episode recordings in a new tab on the documentation site, and update the asset inventory and changelog. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the documentation update, though a full build and browser preview remain unverified.
No open issues 🎉
What changed in this PR
Improves the Spokane Deep Dive documentation experience, following #253’s direct video links, while preserving embedded playback and English captions.
Changes:
- Opens all six episode links in new tabs with
noopener noreferrer. - Adds episode-specific JPEG poster references to the embedded players without changing video sources, captions, or playback settings.
- Updates the asset inventory and changelog.
A full documentation build and browser preview remain unverified.
| File | Description |
|---|---|
docs/usage/spokane-deep-dive.md |
Adds new-tab episode links and video preview posters. |
docs/README.md |
Includes JPEG previews in the documentation asset inventory. |
CHANGELOG.md |
Records the preview and new-tab link improvements. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve the Spokane Deep Dive viewing experience on the documentation site.
All six episode links now open their published MP4 in a new tab with
rel="noopener noreferrer", so readers keep the walkthrough page open.Each embedded player now has a lightweight JPEG poster extracted from its
own video, rather than appearing empty before playback. The original videos,
English caption tracks, playback controls, and
preload="none"remain unchanged.Update the documentation asset inventory and changelog.
Follow-up to #253. No GitHub issue was filed.
Type of change
Checklist
cd hastelib && hatch run test:pytest) and the UI lints clean (cd ui && npm run lint)Testing
python C:\Users\v-marcelod\.copilot\session-state\504d4bdb-edae-4476-bea2-538bdd615b22\files\verify_spokane_videos.py-- passed. Session-local assertions verify all six distinct published MP4 URLs, safe new-tab attributes, valid matching JPEG posters, and unchanged video sources, caption tracks, and player settings againstorigin/main.C:\Users\v-marcelod\.copilot\session-state\504d4bdb-edae-4476-bea2-538bdd615b22\files\docs-preview-venv\Scripts\python.exe -m pre_commit run-- passed: detect-secrets passed; Black, isort, and flake8 skipped because no Python files changed.git diff --cached --check-- passed.py -3.11 -m jupyter_book build docs-- failed before building:jupyter_bookis not installed. Dependency restoration encountered unavailable packages in the configured feed; the subsequent installation attempt was interrupted. A full documentation build and browser preview have not been verified.No persistent automated tests were added. Backend tests
(
cd hastelib && hatch run test:pytest) and UI lint (cd ui && npm run lint)were not run because only documentation and JPEG assets changed.
Additional context
target="_blank"in its Markdown preview; the new-tab behavior applies to the generated documentation site.