eng/pipeline: allow test retries after result publishing - #2445
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure DevOps pipeline stage template to ensure test retry attempts are not blocked by failures in intermediate PublishTestResults tasks, keeping the existing retry gating (succeeded()) intact while allowing expected failed-test outcomes to proceed to the next attempt.
Changes:
- Mark non-final
PublishTestResults@2tasks ascontinueOnError: trueso intermediate failed-test publishing does not transition the job into a Failed state and skip remaining retries.
Show a summary per file
| File | Description |
|---|---|
| eng/pipeline/stages/run-stage.yml | Allows intermediate test result publishing to be non-fatal so retry attempts can continue. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
George Adams (gdams)
force-pushed
the
dev/gadams/macosretry
branch
from
August 11, 2026 13:49
e819d03 to
28108bf
Compare
Davis Goodin (dagood)
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test retry attempts currently require the job to be in a successful state. Non-final test commands use
ignoreLASTEXITCODE, butPublishTestResultscan still fail after publishing a failed JUnit result. That changes the job state before the next test attempt evaluates itssucceeded()condition, causing all remaining retries to be skipped.Mark non-final result-publishing tasks with
continueOnError. Their expected failed-test result becomesSucceededWithIssues, which permits the existing retry condition to continue without weakening its protection against catastrophic build failures. Apply the same behavior to the final publisher for builders markedbroken, preserving the existing policy that their final test failure is non-fatal.Validation:
go test ./cmd/pipelineymlgengit diff --checkFixes #2264