feat(react-spinbutton): add useSpinButtonBase_unstable hook#35907
Draft
dmytrokirpa wants to merge 1 commit intomicrosoft:masterfrom
Draft
feat(react-spinbutton): add useSpinButtonBase_unstable hook#35907dmytrokirpa wants to merge 1 commit intomicrosoft:masterfrom
dmytrokirpa wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Adds `useSpinButtonBase_unstable` hook and `SpinButtonBaseProps`/`SpinButtonBaseState` types that expose the core ARIA/keyboard/value-tracking logic without design-specific props (`appearance`, `size`). The styled `useSpinButton_unstable` now delegates to the base hook and applies the default icon children (ChevronUp16Regular/ChevronDown16Regular), field control props, and overrides. Updates `renderSpinButton_unstable` to accept `SpinButtonBaseState`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Charts-DonutChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-DonutChart.Dynamic - RTL.default.chromium.png | 5570 | Changed |
| vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png | 5581 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 623 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 727 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - Dark Mode.chromium.png | 658 | Changed |
| vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png | 1319 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSpinButtonBase_unstablehook andSpinButtonBaseProps/SpinButtonBaseStatetypes (DistributiveOmit<..., 'appearance' | 'size'>)useSpinButton_unstabledelegates to base hook, then adds field control props, overrides, default icon children (ChevronUp16Regular/ChevronDown16Regular), and design propsrenderSpinButton_unstableto acceptSpinButtonBaseState(render only uses slots)// eslint-disable-next-line react-compiler/react-compilerat theinputRef.current.ariaValueNowassignment that the compiler flags after the refactoring (same pattern used in other components)Test plan
yarn nx build react-spinbutton— passes, API md updatedyarn nx lint react-spinbutton— passesyarn nx test react-spinbutton— 94 tests passPart of #35562
🤖 Generated with Claude Code