Add compile commands - #108
Merged
Chenglong Wang (Chenglong-MS) merged 2 commits intoSep 1, 2026
Merged
Conversation
Author
|
@microsoft-github-policy-service agree |
IAMkecheng
reviewed
Sep 1, 2026
IAMkecheng
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR — I tried this locally and it works well (compile tests + smoke: SVG/PNG, relative data.url, echarts, and the chartjs+svg rejection). The change is additive and doesn’t appear to break the existing flint-chart-mcp path.
Approve with a couple of nits:
- Binary name. I’d prefer renaming the top-level binary from flint to flint-chart. flint alone is a bit too generic and easy to collide with other tools; flint-chart matches the product/repo naming and pairs cleanly with flint-chart-mcp (flint-chart for local CLI work, flint-chart-mcp for the server). Keeping the compile subcommand is fine, e.g. flint-chart compile chart.json --format svg.
- Docs. Please follow up (in this PR or a quick follow-up) with a short section in packages/flint-mcp/README.md documenting flint compile (basic usage, --format / --backend / -o, and how relative data.url resolves).
Overall, it's a nice fix for #107.
Author
|
Updated per your feedback, PTAL when you get a chance |
Contributor
|
Thank you both! Merging to the dev branch to stage for the next release. Btw, if you are feeling adventurous, you are welcome to explore some of the interactive feature we are releasing soon in the dev branch. Available in the playground once you launch the local site: http://localhost:5274/#/playground/click-focus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #107
I used AI, but I've reviewed the output