Fix installation of winget modules for winget and git-clone#124
Merged
DavidObando merged 1 commit intomainfrom May 7, 2025
Merged
Fix installation of winget modules for winget and git-clone#124DavidObando merged 1 commit intomainfrom
DavidObando merged 1 commit intomainfrom
Conversation
Whenever we run winget commandlets in our scripts, we always run them under powershell 7 (pwsh.exe) given its broader compatibility. However, during the installation of winget modules, we sometimes evaluate if the modules are installed under powershell 5 instead of the desired target of powershell 7. This diff fixes it to always target powershell 7.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the installation process of winget modules by ensuring that all commands run under PowerShell 7 (pwsh.exe) rather than PowerShell 5.
- Retrieve module information using pwsh.exe -Command to enforce the correct PowerShell version.
- Remove explicit required version parameters from installation commands.
- Add the -AllowPrerelease flag for the Microsoft.WinGet.Configuration module installation in the git-clone script.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Tasks/winget/main.ps1 | Updated module retrieval and installation commands to always use pwsh.exe and removed version requirements. |
| Tasks/git-clone/main.ps1 | Updated module retrieval and installation commands, including the addition of the -AllowPrerelease flag for configuration. |
antonellaavogadro
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever we run winget commandlets in our scripts, we always run them under powershell 7 (pwsh.exe) given its broader compatibility. However, during the installation of winget modules, we sometimes evaluate if the modules are installed under powershell 5 instead of the desired target of powershell 7. This diff fixes it to always target powershell 7.