Skip to content

Skip signed PowerShell profiles instead of breaking them (fixes #161) #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lili离 (Uarz) wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

Skip signed PowerShell profiles instead of breaking them (fixes #161) #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/pwsh-install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,18 @@ function Update-PowerShellProfile([string]$Path, [bool] $Install, [bool] $UseBom
$Path = $profile.ResolvedTarget
}

# A signed PowerShell profile cannot be modified without invalidating its
# Authenticode signature, which breaks profile loading under signed
# execution policies (AllSigned/etc.). Detect such profiles and skip them
# instead of silently breaking them. See microsoft/coreutils#161.
if (Test-Path -LiteralPath $Path) {
$signature = Get-AuthenticodeSignature -LiteralPath $Path -ErrorAction Ignore
if ($null -ne $signature -and $signature.Status -ne 'NotSigned') {
Write-Warning "Skipping signed PowerShell profile '$Path': modifying it would break its Authenticode signature. coreutils commands will not be available in this profile."
return
}
}

# Get-Content uses .NET's StreamReader, so it auto-detects UTF-8/UTF-16 with BOM.
$text = Get-Content -LiteralPath $Path -Raw -ErrorAction Ignore
if (!$text) {
Expand Down