Repository navigation
Fix #187: Report warnings and infos from get_errors - #516
Open
Lars Vogel (vogella) wants to merge 1 commit into
Open
Lars Vogel (vogella) wants to merge 1 commit into
Lars Vogel (vogella) wants to merge 1 commit into
Conversation
The get_errors tool only returned error markers, printed as raw marker dumps, so Copilot could not see the warnings and infos the Problems view shows. It now lists every problem marker of the requested files with its severity, line and message, errors first, and says when a file has no problems. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Lars Vogel (vogella)
requested review from
Ethan Hou (ethanyhou),
Sheng Chen (jdneo) and
xinyi-gong
as code owners
November 6, 2026 08:11
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change extending get_errors to include warning and informational diagnostics.
No open issues 🎉
What changed in this PR
Extends get_errors to report warnings and informational problems alongside errors, addressing #187’s gap in Copilot’s access to Eclipse Problems view diagnostics.
Changes:
- Formats problems with severity, optional line number, and message, ordered by severity and then line.
- Explicitly reports files with no problems and updates tool descriptions without changing the input structure.
- Adds tests for severity ordering, missing line numbers, and empty marker lists.
| File | Description |
|---|---|
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/tools/GetErrorsTool.java | Reports all problem severities in readable, sorted output. |
| com.microsoft.copilot.eclipse.ui.test/src/com/microsoft/copilot/eclipse/ui/chat/tools/GetErrorsToolTests.java | Adds formatting, ordering, and empty-result tests. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get_errors tool only passed error markers to the model, so Copilot could not see the warnings and infos that the user sees in the Problems view, which is the gap discussed in #187. It now reports every problem marker of the requested files with its severity, line number and message, errors first and each group ordered by line, and states when a file has no problems instead of returning an empty result. Each problem is one readable line instead of the raw marker dump, which also keeps the tool output shorter for the model. The tool keeps its name and input schema, only its description mentions the additional severities. Fixes #187.