Repository navigation
Fix NPE and lost chat requests while models are not loaded yet - #503
Merged
Merged
Conversation
Dietrich Travkin (travkin79)
requested review from
Ethan Hou (ethanyhou),
Sheng Chen (jdneo) and
xinyi-gong
as code owners
October 23, 2026 16:30
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Partial-fetch preference loss and availability-binding lifecycle issues remain unresolved.
3 open issues
What changed in this PR
This PR addresses #408 by preventing chat submission before a model is available and handling delayed or failed model loading. It complements the separate preference-loading and shutdown fixes.
Changes:
- Fetch Copilot and BYOK model lists in parallel, allowing activation despite one list failing.
- Disable sending while models load and add null-safe chat request and tooltip handling.
- Add regression tests for model loading, availability notifications, and missing-model requests.
| File | Description |
|---|---|
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/i18n/messages.properties |
Adds model-loading placeholder and tooltip text. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/i18n/Messages.java |
Declares the new localized messages. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/services/ModelService.java |
Loads model lists concurrently and observes availability. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/ReferencedFile.java |
Handles image tooltips without an active model. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/ChatView.java |
Rejects premature sends while preserving input. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/ChatInputTextViewer.java |
Displays the model-loading placeholder. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/ActionBar.java |
Gates sending on model availability. |
com.microsoft.copilot.eclipse.ui.test/src/com/microsoft/copilot/eclipse/ui/chat/services/ModelServiceTests.java |
Tests parallel loading, partial failures, and availability. |
com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/lsp/CopilotLanguageServerConnection.java |
Returns failed futures for requests without a model. |
com.microsoft.copilot.eclipse.core.test/src/com/microsoft/copilot/eclipse/core/lsp/CopilotLanguageServerConnectionTests.java |
Verifies missing-model requests never reach the server. |
Review effort: Balanced
Member
|
Hi Dietrich Travkin (@travkin79) Thank you for your contribution. Could you please check those copilot comment? |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Dietrich Travkin (travkin79)
force-pushed
the
fix-408-npe
branch
from
October 26, 2026 11:00
2ffa519 to
abfa462
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
With preview features enabled, switching chat modes while models are pending can enable the delegation button even though sending is rejected without an active model.
1 open issue
3 resolved since last review
Review effort: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Dietrich Travkin (travkin79)
force-pushed
the
fix-408-npe
branch
from
October 28, 2026 11:33
abfa462 to
bee8766
Compare
Sheng Chen (jdneo)
approved these changes
Oct 29, 2026
Sheng Chen (jdneo)
left a comment
Sheng Chen (jdneo)
left a comment
Member
There was a problem hiding this comment.
LGTM, thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #408
When the Copilot language server (CLS) is busy, e.g. for minutes after startup in large workspaces, the
model lists arrive late. Until then there is no active model, and sending a chat request fails with an NPE.
Changes
createConversation,addConversationTurn, pressing Enter, referenced-file tooltip).This does not fix the busy CLS itself. It complements #452 – #455, which address UI freezes and shutdown hangs.