Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the consent storage mechanism to store consent data using the internal processing format (ConsentData with BooleanFlag values) instead of the external API format (ConsentState with string values). This eliminates redundant conversions and simplifies the consent tracking flow.
Key Changes:
- Changed internal storage type from
ConsentState(string-based) toConsentData(BooleanFlag-based) - Added
getConsentState()helper function to convert internal format to external format when needed - Simplified consent initialization and tracking by removing intermediate conversions
Comments suppressed due to low confidence (1)
packages/clarity-js/src/data/metadata.ts:159
- Avoid automated semicolon insertion (94% of all statements in the enclosing function have an explicit semicolon).
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
toby-walker
reviewed
Dec 10, 2025
toby-walker
reviewed
Dec 10, 2025
toby-walker
reviewed
Dec 10, 2025
toby-walker
reviewed
Dec 10, 2025
117a88e to
662ceb3
Compare
bb346a0 to
5f10156
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to store consent type as the values used for processing instead of object sent by site.