make non-http panel links non-clickable#15514
make non-http panel links non-clickable#15514adamint wants to merge 2 commits intomicrosoft:mainfrom
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15514Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15514" |
There was a problem hiding this comment.
Pull request overview
Updates the Aspire VS Code extension’s running App Hosts tree so that only HTTP/HTTPS endpoints behave like “openable” links, preventing non-HTTP endpoints (e.g., SQL/TCP) from showing as clickable browser targets.
Changes:
- Make endpoint tree items clickable (and show “open” affordances) only when the URL is HTTP/HTTPS.
- Add a separate context value for non-HTTP endpoints and adjust the context-menu “Copy endpoint URL” visibility to include them.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| extension/src/views/AspireAppHostTreeProvider.ts | Conditionally assigns link icon + vscode.open command only for HTTP/HTTPS endpoints; adds non-HTTP endpoint context value. |
| extension/package.json | Broadens the “Copy endpoint URL” context-menu visibility to match both HTTP and non-HTTP endpoint items. |
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
| arguments: [vscode.Uri.parse(url)] | ||
| }; | ||
|
|
||
| const isHttpUrl = url.startsWith('http://') || url.startsWith('https://'); |
There was a problem hiding this comment.
Does this need to worry about case? i.e. HTTP://
There was a problem hiding this comment.
Yea, it should be case insensitive. Updated
Description
Fixes #15472
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: