Conversation
…re.EndToEnd.Tests Co-authored-by: radical <1472+radical@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/aspire/sessions/421f8f4c-6f5d-4969-9e76-0e274d38c3ff
Copilot created this pull request from a session on behalf of
radical
March 23, 2026 20:07
View session
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15501Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15501" |
radical
added
the
area-engineering-systems
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Aspire end-to-end test project to avoid running Docker-dependent tests on macOS GitHub Actions runners (where Docker isn’t available), while still allowing Docker gating via the repo’s RequiresFeature mechanism.
Changes:
- Excludes
Aspire.EndToEnd.Testsfrom macOS GitHub Actions runs via MSBuild property. - Adds
RequiresFeature(TestFeature.Docker)guards to Docker-dependent E2E tests inIntegrationServicesTests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/Aspire.EndToEnd.Tests/IntegrationServicesTests.cs | Adds Docker feature requirement attributes to relevant E2E tests. |
| tests/Aspire.EndToEnd.Tests/Aspire.EndToEnd.Tests.csproj | Disables running this test project on GitHub Actions macOS runners; updates related comment. |
Comment on lines
22
to
25
| [Theory] | ||
| [OuterloopTest("EndToEnd tests require Docker and are slow")] | ||
| [RequiresFeature(TestFeature.Docker)] | ||
| [Trait("scenario", "basicservices")] |
There was a problem hiding this comment.
Consider applying RequiresFeature(TestFeature.Docker) at the test class level instead of per-test. That avoids duplication and prevents new tests added to this class from accidentally running on unsupported CI environments if the attribute is forgotten.
Comment on lines
+7
to
+9
| <!-- Only run on Linux; no docker support on Windows/Mac yet --> | ||
| <RunOnGithubActionsWindows>false</RunOnGithubActionsWindows> | ||
| <RunOnGithubActionsMacOS>false</RunOnGithubActionsMacOS> |
There was a problem hiding this comment.
The comment says "no docker support on Windows/Mac yet", but this project property is specifically about where tests run in GitHub Actions. To avoid implying Docker is unsupported on macOS/Windows in general (e.g., local dev), consider wording this as "no Docker support on GitHub Actions Windows/macOS" or "no Docker support on CI Windows/macOS".
adamint
approved these changes
Mar 23, 2026
auto-merge was automatically disabled
March 24, 2026 16:35
Pull request was closed
Contributor
|
🎬 CLI E2E Test Recordings — 49 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23500902944 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
End-to-end tests in
Aspire.EndToEnd.Testsrequire Docker, which is unavailable on macOS CI runners. This adds both a project-level CI exclusion and per-test guards.Changes:
Aspire.EndToEnd.Tests.csproj: Added<RunOnGithubActionsMacOS>false</RunOnGithubActionsMacOS>(alongside existing Windows exclusion); updated comment to reflect both platformsIntegrationServicesTests.cs: Added[RequiresFeature(TestFeature.Docker)]toVerifyComponentWorksandVerifyHealthyOnIntegrationServiceA— ensures tests are skipped at runtime on any environment without Docker supportFixes #15500 .
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: