-
Notifications
You must be signed in to change notification settings - Fork 30
spec: multiroot sessions (draft for feedback) #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sandy081
merged 17 commits into
main
from
sandy081/agents/multiroot-sessions-support-spec
Jul 22, 2026
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5d2a82e
spec: add multiroot session support (AHP 0.6.0)
sandy081 d53cdac
spec: per-chat working-directory subsets (AHP 0.6.0)
sandy081 2bd50e6
spec: group multiroot changes by working directory + proposal doc
sandy081 4bcb754
spec: use @version 1 for new multiroot commands (JSDoc convention)
sandy081 71d6b5f
spec: fix @version on ping (0.1.0 -> 1)
sandy081 189f46c
docs: add type-change summary to multiroot proposal
sandy081 5495b7f
spec: address review feedback on multiroot PR #337
sandy081 1ebc206
spec: rename capability + drop Changeset.workingDirectory (review rou…
sandy081 64349e5
Merge remote-tracking branch 'origin/main' into sandy081/agents/multi…
sandy081 11f1a65
fix(clients): implement working-directory actions in native reducers
sandy081 f2be3ad
Merge remote-tracking branch 'origin/main' into sandy081/agents/multi…
sandy081 40eb488
spec: target 0.7.0 for multiroot (0.6.0 shipped without it)
sandy081 0d715aa
Revert "spec: target 0.7.0 for multiroot (0.6.0 shipped without it)"
sandy081 d7c7d5a
Reapply "spec: target 0.7.0 for multiroot (0.6.0 shipped without it)"
sandy081 148c716
spec: rename requiresPrimary + add primaryWorkingDirectory (session +…
sandy081 ea279d9
spec: make primaryWorkingDirectory a per-chat, read-only, creation-fi…
sandy081 d533dbd
docs: explain why primaryWorkingDirectory is on CreateSessionParams
sandy081 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI Review:
omitemptycollapses a present-but-empty slice into an absent field, but the chat contract distinguishes explicit empty (no working-directory access) from absent (inherit the session set). Can the Go representation preserve that distinction, or should the protocol drop the explicit-empty semantic?