Fix: Fail and warn the user when --uninstall is given parameters#14524
Merged
chemwolf6922 merged 4 commits intomasterfrom Mar 25, 2026
Conversation
Contributor
Author
|
Recreating #14507 as the original PR is stuck on github. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates wsl.exe argument parsing to prevent accidental full WSL uninstalls when users mistakenly pass a distro name to --uninstall (a common confusion with --unregister).
Changes:
- Rejects any extra arguments after
--uninstalland prints a localized guidance message pointing users to--unregister. - Adds a unit test validating the new rejection behavior and exit code.
- Introduces a new localized string for the user-facing message.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/windows/common/WslClient.cpp |
Adds validation to fail fast if --uninstall is followed by any additional token(s). |
test/windows/UnitTests.cpp |
Adds a unit test asserting the new output and -1 exit code for --uninstall <arg>. |
localization/strings/en-US/Resources.resw |
Adds the new localized message string used by the CLI. |
benhillis
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fail and warn the user when --uninstall is given parameters. The user is likely misusing the command to uninstall the distro instead of uninstall WSL.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
wsl --uninstall Ubuntu