Skip to content

Sign wslcsdk.dll in the release pipeline#14517

Merged
OneBlue merged 1 commit intofeature/wsl-for-appsfrom
user/oneblue/sdk-sign
Mar 24, 2026
Merged

Sign wslcsdk.dll in the release pipeline#14517
OneBlue merged 1 commit intofeature/wsl-for-appsfrom
user/oneblue/sdk-sign

Conversation

@OneBlue
Copy link
Collaborator

@OneBlue OneBlue commented Mar 24, 2026

Summary of the Pull Request

This change adds logic to sign wslcsdk.dll

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copilot AI review requested due to automatic review settings March 24, 2026 05:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the release build stage pipeline to ensure wslcsdk.dll is included in the ESRP code-signing pass, aligning the pipeline output with the SDK/NuGet packaging inputs that consume bin\<arch>\Release\wslcsdk.dll.

Changes:

  • Add the wslcsdk CMake target to the set of release pipeline build targets.
  • Add wslcsdk.dll to the code-signing/copy-to-staging pattern list used by the ESRP signing step.

@OneBlue OneBlue changed the title Signal wslcsdk.dll in the release pipeline Sign wslcsdk.dll in the release pipeline Mar 24, 2026
@OneBlue OneBlue marked this pull request as ready for review March 24, 2026 17:52
@OneBlue OneBlue requested a review from a team as a code owner March 24, 2026 17:52
@OneBlue OneBlue merged commit 99027a3 into feature/wsl-for-apps Mar 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants