Skip to content

MAINT: Set PYRIT_CORS_ORIGINS env var in Bicep instead of imperatively #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adrian-gavrila wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −6
Open

MAINT: Set PYRIT_CORS_ORIGINS env var in Bicep instead of imperatively #1646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4d2bd4
Set PYRIT_CORS_ORIGINS env var in Bicep instead of imperatively
Apr 23, 2026
4f9d015
Clean up comments in main.bicep
adrian-gavrila Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions infra/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,12 +388,6 @@ az deployment group create \
4. **Manage access** — Add or remove users via Entra security groups
(`allowedGroupObjectIds`). Each group must also be assigned to the enterprise app.

5. **Set CORS origins** for production (the Bicep template does not set this):
```bash
az containerapp update -n <appName> -g <rg> \
--set-env-vars "PYRIT_CORS_ORIGINS=https://$FQDN"
```

## Access the GUI

```bash
Expand Down
7 changes: 7 additions & 0 deletions infra/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,13 @@ resource containerApp 'Microsoft.App/containerApps@2024-03-01' = {
name: 'AZURE_CLIENT_ID'
value: managedIdentity.properties.clientId
}
// CORS origin for the SPA. The ACA-generated FQDN is deterministic
// (<appName>.<envDefaultDomain>), so we compute it from upstream
// resources rather than self-referencing containerApp.
{
name: 'PYRIT_CORS_ORIGINS'
value: 'https://${appName}.${acaEnvironment.properties.defaultDomain}'
}
]
}
]
Expand Down
Loading