FEAT: Searchable multi-select filters for Attack History (ADO 7834)#1643
Open
adrian-gavrila wants to merge 7 commits intomicrosoft:mainfrom
Open
FEAT: Searchable multi-select filters for Attack History (ADO 7834)#1643adrian-gavrila wants to merge 7 commits intomicrosoft:mainfrom
adrian-gavrila wants to merge 7 commits intomicrosoft:mainfrom
Conversation
…ilter" Add a tri-state has_converters param to get_attack_results. Previously converter_classes=[] meant "attacks with no converters"; it now means "no filter". Use has_converters=False for the old behavior. BREAKING CHANGE: converter_classes=[] no longer filters to zero-converter attacks. No in-repo callers relied on this. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update the AttackService and REST route to forward the new has_converters param to memory, and rename the route query param from attack_class (scalar) to attack_types (repeated) for consistency with the other list-valued filters. BREAKING CHANGE: REST query param attack_class renamed to attack_types. Only in-tree consumer is the frontend, updated in the next commit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace Dropdowns with searchable multi-select Comboboxes for attack class, converter, operator, and operation filters. The converter Combobox includes a "(No converters)" sentinel option that maps to has_converters=false. A match-mode Switch (ANY|ALL) appears when two or more converters are selected. Adapts AttackHistory.fetchAttacks to send attack_types (repeated), converter_types_match, and has_converters to the API. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…] semantic) Restores the deprecated singular `attack_class` parameter as a forwarder to `attack_classes` and reverts `converter_classes=[]` to its original "no converters" meaning. Library callers see no behavior change; the new `attack_classes`/`has_converters` params remain available for explicit multi/presence filtering. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Multi-select Comboboxes now display "<first> (+N)" instead of always showing the placeholder. Swaps the outcome filter from Dropdown to single-select Combobox so its visible label persists across re-renders triggered by sibling filter changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ce label keys - Service layer coerces converter_types=[] to 'no filter'; the 'no converters' intent is expressed via has_converters=False. Keeps route/service/memory semantics consistent. - memory_interface.get_attack_results strips label keys whose value is an empty sequence before emitting the label condition (previously produced a strictly-more-restrictive EXISTS predicate). - Skip the redundant has_converters=True predicate when converter_classes is already non-empty. - Adds unit tests for the empty-sequence/no-identifier branches in the memory and backend service layers. - Fixes two Attack History e2e specs to click the Combobox input (Fluent v9 multiselect doesn't open the listbox on wrapper click). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Fluent v9 multiselect Combobox renders items as role=menuitemcheckbox, not role=option. Update attack-class and operator filter tests to query the correct role. - Update the mockHistoryAPIs handler to read the renamed attack_types (plural, repeatable) query param and to group repeated label keys into OR-sets (matches the route's real semantic). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the Attack History view's Fluent UI Dropdowns to searchable multi-select Comboboxes and expands backend filter semantics to support the new UX. Resolves ADO 7834.
User-visible changes
(+N)suffix when more than one is selected.(No converters)option, mutually exclusive with picking specific converters.Match any | Match allSwitch controls whether an attack must use any or all of them.REST contract change
GET /attacksquery paramattack_classis renamed toattack_types(repeated, list-valued) to align with the multi-select UI and the already-existingGET /attack-optionsresponse field. The only in-tree consumer is the frontend, updated in this PR.Memory layer additions (non-breaking)
MemoryInterface.get_attack_resultsgains a newattack_classes: Sequence[str]param for OR-matched multi-filtering, plushas_converters: bool | Nonefor explicit presence/absence filtering. The oldattack_class: strparam is preserved as a deprecated forwarder, andconverter_classes=[]keeps its original "no converters" semantic.Tests and Documentation
Tests added
attack_classesmulti-match,has_converters=True/False, back-compat of singularattack_class, and theValueErrorwhen both singular and plural are passed.has_convertersforwarding, match-mode combinations,attack_typeslist handling.attack_types,converter_types_matchany/all,has_converterswiring.has_convertersAPI forwarding, conditionalconverter_types_matchemission, multi-select display formatting, outcome filter label persistence.Documentation: updated relevant docstrings, but no changes to other documentation