Remove PowerFxConfig.AdditionalFunctions#3056
Open
anderson-joyle wants to merge 1 commit intomainfrom
Open
Conversation
anderson-joyle
changed the title
Contributor
|
✅ No public API change. |
The AdditionalFunctions dictionary on PowerFxConfig (in Fx.Core) mapped TexlFunction keys to IAsyncTexlFunction implementations from the Interpreter, a layering violation since Core should not reference Interpreter implementation types. Migrate the single producer (EnableRegExFunctions) to the same pattern already used by Join, Patch, and Set: a class that derives from the Core TexlFunction base and also implements the interpreter interface. Three thin wrapper classes (IsMatchImpl, MatchImpl, MatchAllImpl) in LibraryRegEx.cs inherit IsMatchFunction/MatchFunction/MatchAllFunction and delegate InvokeAsync to the existing Implementation classes. With that, registration is a plain symbolTable.AddFunction call and the EvalVisitor `func is IAsyncTexlFunction` branch handles dispatch. The field, its plumbing through ParsedExpression and EvalVisitor, and the matching test helpers for NodeJS/PCRE2/Compare are all removed. No public API change. All 64,946 interpreter tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
anderson-joyle
force-pushed
the
fix/remove-additional-functions-2821
branch
from
f9ad83c to
1451308
Compare
anderson-joyle
changed the title
Contributor
|
✅ No public API change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2821
The AdditionalFunctions dictionary on PowerFxConfig (in Fx.Core) mapped TexlFunction keys to IAsyncTexlFunction implementations from the Interpreter, a layering violation since Core should not reference Interpreter implementation types.
Migrate the single producer (EnableRegExFunctions) to the same pattern already used by Join, Patch, and Set: a class that derives from the Core TexlFunction base and also implements the interpreter interface. Three thin wrapper classes (IsMatchImpl, MatchImpl, MatchAllImpl) in LibraryRegEx.cs inherit IsMatchFunction/MatchFunction/MatchAllFunction and delegate InvokeAsync to the existing Implementation classes.
With that, registration is a plain symbolTable.AddFunction call and the EvalVisitor
func is IAsyncTexlFunctionbranch handles dispatch. The field, its plumbing through ParsedExpression and EvalVisitor, and the matching test helpers for NodeJS/PCRE2/Compare are all removed.No public API change. All 64,946 interpreter tests pass.