Summarize aggregate scope includes scalar groupby keys#3055
Open
anderson-joyle wants to merge 1 commit intomainfrom
Open
Summarize aggregate scope includes scalar groupby keys#3055anderson-joyle wants to merge 1 commit intomainfrom
anderson-joyle wants to merge 1 commit intomainfrom
Conversation
The Summarize runtime was pushing only the group's subset TableValue
into the aggregate lambda's scope. The binder (FunctionThisGroupScopeInfo)
builds the scope DType as { <key>: scalar, ..., ThisGroup: table }, so
FormulaValueScope.Resolve for any bare name fell through to returning the
whole table, making Dec2Hex(<key>, ...) error and Text(<key>) hang.
Build a RecordValue matching the binder's shape (scalar key fields plus
ThisGroup -> group table) and pass that to WithScopeValues. Adds
regression tests covering the Dec2Hex and Text repros from the issue,
equivalence with First(ThisGroup).<field>, and a multi-key groupby.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
anderson-joyle
force-pushed
the
fix/summarize-groupby-field-ref
branch
from
e18ab7e to
aaa4878
Compare
Contributor
|
✅ No public API change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #2876
The Summarize runtime was pushing only the group's subset TableValue into the aggregate lambda's scope. The binder (FunctionThisGroupScopeInfo) builds the scope DType as { : scalar, ..., ThisGroup: table }, so FormulaValueScope.Resolve for any bare name fell through to returning the whole table, making Dec2Hex(, ...) error and Text() hang.
Build a RecordValue matching the binder's shape (scalar key fields plus ThisGroup -> group table) and pass that to WithScopeValues. Adds regression tests covering the Dec2Hex and Text repros from the issue, equivalence with First(ThisGroup)., and a multi-key groupby.