Fix ParseDate to handle non-strict ISO 8601 date formats from connectors#3048
Open
EricBuist wants to merge 3 commits intomicrosoft:mainfrom
Open
Fix ParseDate to handle non-strict ISO 8601 date formats from connectors#3048EricBuist wants to merge 3 commits intomicrosoft:mainfrom
EricBuist wants to merge 3 commits intomicrosoft:mainfrom
Conversation
ParseDate used element.GetDateTime() which only accepts strict ISO 8601. Connector APIs like Jira return valid dates with timezone offsets without colons (e.g. "+0000" instead of "+00:00") that GetDateTime() rejects. Now falls back to DateTimeOffset.TryParse on FormatException, and returns an ErrorValue instead of throwing if both parsers fail. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 3048 in repo microsoft/Power-Fx |
…avior Align DateTimeOffset.TryParse fallback with SwaggerTypeFormatExtensions' ConvertToDate/ConvertToDatetime, which use DateTimeStyles.AssumeUniversal so that date strings without timezone info are treated as UTC. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replaces the GetDateTime-with-fallback logic in FormulaValueJSON.ParseDate with a single DateTimeOffset.TryParse(AssumeUniversal) call. This removes the two-path inconsistency where strict and lenient inputs could differ in how the stored instant was derived, and aligns no-offset inputs with Power Automate / Logic Apps semantics (treated as UTC rather than literal local wall-clock time). Updates PrimitivesTest to express its expected value as the local-time projection of the UTC instant so it remains machine-stable. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseDate used element.GetDateTime() which only accepts strict ISO 8601. Connector APIs like Jira return valid dates with timezone offsets without colons (e.g. "+0000" instead of "+00:00") that GetDateTime() rejects. Now falls back to DateTimeOffset.TryParse on FormatException, and returns an ErrorValue instead of throwing if both parsers fail.