Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the deployment orchestrator workflow and notification job to improve resource cleanup handling and notification accuracy. The most significant changes are the integration of the cleanup job into the workflow, passing its result to the notification job, and enhancing notification content to reflect cleanup status and configuration.
Workflow and Job Integration
cleanup-deploymentjob to.github/workflows/deploy-orchestrator.yml, which runs after deployment and tests, and before notifications. Its result is passed to the notification job for improved reporting.send-notificationwaits forcleanup-deployment, ensuring all stages are completed before notification is sent.cleanup_resultoutput fromcleanup-deploymenttosend-notification, allowing notification emails to include cleanup status.Notification Job Enhancements
cleanup_resultas an input to.github/workflows/job-send-notification.yml, with default value and description.Input and Parameter Handling
e2e_test_resultinput optional with a default value, improving flexibility and robustness.These changes collectively make the workflow more robust by ensuring resource cleanup is tracked and reported, and notifications are more informative for recipients.
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information