Skip to content

ci: refactor Notification formatting#864

Open
Vamshi-Microsoft wants to merge 1 commit intomainfrom
psl-reformat-notifications
Open

ci: refactor Notification formatting#864
Vamshi-Microsoft wants to merge 1 commit intomainfrom
psl-reformat-notifications

Conversation

@Vamshi-Microsoft
Copy link
Contributor

Purpose

This pull request updates the deployment orchestrator workflow and notification job to improve resource cleanup handling and notification accuracy. The most significant changes are the integration of the cleanup job into the workflow, passing its result to the notification job, and enhancing notification content to reflect cleanup status and configuration.

Workflow and Job Integration

  • Added a new cleanup-deployment job to .github/workflows/deploy-orchestrator.yml, which runs after deployment and tests, and before notifications. Its result is passed to the notification job for improved reporting.
  • Updated job dependencies so send-notification waits for cleanup-deployment, ensuring all stages are completed before notification is sent.
  • Passed the cleanup_result output from cleanup-deployment to send-notification, allowing notification emails to include cleanup status.

Notification Job Enhancements

  • Added cleanup_result as an input to .github/workflows/job-send-notification.yml, with default value and description.
  • Added steps to determine cleanup status and configuration label, so notifications can display a summary table of deployment, test, and cleanup results, as well as WAF/EXP configuration.
  • Improved quota failure notification email to include a status summary table and configuration label, making it clearer which stages failed or were skipped and what configuration was used.

Input and Parameter Handling

  • Made e2e_test_result input optional with a default value, improving flexibility and robustness.

These changes collectively make the workflow more robust by ensuring resource cleanup is tracked and reported, and notifications are more informative for recipients.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant