[SM6.10] Complete TriangleObjectPositions implementation #8097
Conversation
- Lowering for all TriangleObjectPositions variants with tests - BuiltInTrianglePositions struct definition and tests - Validation logic with expected pass and fail tests Closes microsoft#8030 microsoft#8031 microsoft#8032 #808033
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
I don't necessarily think this must be addressed before mering, but one minor gripe I have is that neither the dxilgen lowering test nor the end-to-end DXIL test in CodeGenDXIL check that the returned vector components from the DXIL op are linked up correctly to the intended uses.
If you think this needs to be addressed before shipping then we might as well address it now? |
Yeah, I guess addressing this now would be better. |
| ; REQUIRES: dxil-1-10 | ||
|
|
||
| ; CHECK-LABEL: define void {{.*}}ClosestHit | ||
| ; CHECK: %{{.*}} = call <9 x float> @dx.op.triangleObjectPosition.f32(i32 -2147483641) |
There was a problem hiding this comment.
I think we should check that components in the returned vectors for each of these operations are used where expected, which unit-tests that code in HLOperationLower.cpp.
3 participants
Closes #8030 #8031 #8032 #8033