[SM6.10][NFC] DXIL Ops Allow 4 type overloads #8084
Conversation
| # Extended overload slots, extend as needed: | ||
| "$x0": "EXT(0);", | ||
| "$x1": "EXT(1);", | ||
| "$x2": "EXT(2);", |
There was a problem hiding this comment.
This could add these using use a loop based on the dxil_max_overload_dims in hctdb, if we wanted. Then there's only one variable you have to update to change it, and this stays in sync automatically.
I think this should work:
for n in range(self.db.dxil_max_overload_dims):
op_type_texts[f"$x{n}"] = f"EXT({n});"
There was a problem hiding this comment.
Alternative viewpoint: after spending lots of time trawling through the codebase looking for things that are programmatically generated, I prefer the explicit, greppable version.
I trust @V-FEXrt to make the right call here, one way or the other.
There was a problem hiding this comment.
Yeah I'd personally lean towards leaving it hard coded. I found it myself by grepping and my search wouldn't have matched this loop
| # Extended overload slots, extend as needed: | ||
| "$x0": "EXT(0);", | ||
| "$x1": "EXT(1);", | ||
| "$x2": "EXT(2);", |
There was a problem hiding this comment.
Alternative viewpoint: after spending lots of time trawling through the codebase looking for things that are programmatically generated, I prefer the explicit, greppable version.
I trust @V-FEXrt to make the right call here, one way or the other.
V-FEXrt
changed the title
3 participants
The LinAlg spec requires certain new DXIL opcodes to have 4 type overloads. This NFC change updates the infrastructure to support that