-
Notifications
You must be signed in to change notification settings - Fork 828
[SPIR-V] Add vk::SampledTexture2D resource type and .Sample(), .CalculateLevelOfDetail() method.
#8047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
s-perron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a reasonable direction. There are some issues that we need to figure out how to handle.
67fef39 to
8030b4e
Compare
|
Thanks for the early review! I've updated the method to take in optional arguments. |
vk::SampledTexture2D resource type and .Sample() method.vk::SampledTexture2D resource type and .Sample(), CalculateLevelOfDetail() method.
vk::SampledTexture2D resource type and .Sample(), CalculateLevelOfDetail() method.vk::SampledTexture2D resource type and .Sample(), .CalculateLevelOfDetail() method.
6bc83c2 to
eb29b1b
Compare
eb29b1b to
03b6051
Compare
ea6ac39 to
389cd0f
Compare
|
If this is worth mentioning in the release notes, please add something to https://github.com/microsoft/DirectXShaderCompiler/blob/main/docs/ReleaseNotes.md as appropriate. |
s-perron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good to me. A few minor code style issues to fix up.
It will not be fully completed for this release. We should mention it in the next. |
fae5ab0 to
aead4cc
Compare
aead4cc to
e6d978f
Compare
s-perron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good now. Just one minor change.
bogner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor comments but otherwise LGTM
Part of #7979
SampledTexture2Dresource type in thevknamespace..Sample(float2 location)method.float4.int2 offset, float clamp, uint status..CalculateLevelOfDetail(float2 location)method.