[HLSL] fix case-sensitive semantics for workgraphs #8029
+38
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function handling semantics for work graphs were case sensitive, but shouldn't. This commit addresses that. Fixes microsoft#8014
luciechoi
approved these changes
Jan 7, 2026
s-perron
approved these changes
Jan 7, 2026
Collaborator
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
Fine with me. We should double check with someone from MS as this affects them too.
Member
|
If this is worth mentioning in the release notes, please add something to https://github.com/microsoft/DirectXShaderCompiler/blob/main/docs/ReleaseNotes.md as appropriate. |
s-perron
approved these changes
Jan 20, 2026
Collaborator
Author
|
@damyanp is this OK for MS? |
Member
|
@amarpMSFT / @tex3d - do you have any concerns with this change? |
Collaborator
Seems fine to me assuming this brings consistency with other semantics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function handling semantics for work graphs were case sensitive, but shouldn't. This commit addresses that.
Fixes #8014