Corrected setting IRBuilder debug location in HLSignatureLower::Gener… #8022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ateDxilComputeAndNodeCommonInputs()
Member
|
@adam-yang - can you have a look at this when you get a chance please? @kpyzhov - it seems like there may be some kind of a testing hole that we should fill along with this fix? |
adam-yang
reviewed
Jan 5, 2026
tools/clang/test/HLSLFileCheck/dxil/debug/dxop_threadid_dbgloc.hlsl
Outdated
Show resolved
Hide resolved
Author
|
@adam-yang, can you approve it again please? Thanks! |
Author
|
@damyanp, I'm seeing the "microsoft.DirectXShaderCompiler" check has been in the "waiting" state for a long time. Is that some testing that I have to run manually? Thanks! |
tex3d
approved these changes
Jan 22, 2026
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ateDxilComputeAndNodeCommonInputs()
As a result of #7799, the HLSL entry function can now contain
dbg.valuecalls with !dbg location metadata with scopes corresponding to functions which have been inlined.The
HLSignatureLower::GenerateDxilComputeAndNodeCommonInputs()creates@dx.op.threadIdintrinsic calls, using the default dbg loc when creating anIRBuilder. When the first instruction in the entry block is one of thedbg,valuecalls, its dbg location is copied to the@dx.op.threadIdcalls. That makes the DXIL unreadable by the modern LLVM IR reader since it fails the IR module verification because of !dbg pointing to a different subprogram scope.This change sets the dbg location for IRBuilder to be the !dbg node of the first non-PHI and non-debug instruction in the block.