fix: Update parameters for AI services and remove secondary location references#142
Closed
Prachig-Microsoft wants to merge 3 commits intodevfrom
Closed
fix: Update parameters for AI services and remove secondary location references#142Prachig-Microsoft wants to merge 3 commits intodevfrom
Prachig-Microsoft wants to merge 3 commits intodevfrom
Conversation
Prachig-Microsoft
requested review from
Avijit-Microsoft,
Dongbumlee,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
nchandhi,
sethsteenken and
toherman-msft
as code owners
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Prachig-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
- Reverted containerRegistryHost to use AZURE_CONTAINER_REGISTRY_HOST - Reverted AI model parameters to use AZURE_AI_MODEL_NAME, AZURE_AI_MODEL_VERSION, AZURE_AI_MODEL_CAPACITY - Reverted deployment type to use AZURE_AI_DEPLOYMENT_TYPE - Removed enableTelemetry parameter customization (uses bicep default) - Updated workflow files and documentation to reflect original naming - Kept AZURE_ENV_ prefix only for: AI_SERVICE_LOCATION, LOG_ANALYTICS_WORKSPACE_RID, FOUNDRY_PROJECT_RID, VM_ADMIN credentials, IMAGETAG
Author
|
Validation in progress for latest commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates environment parameter documentation and infrastructure parameter files to better align with current Azure resource requirements and simplify configuration. The main changes are the removal of unused parameters and the addition of new, optional parameters for advanced scenarios.
Parameter documentation updates:
AZURE_SECONDARY_LOCATIONparameter and its references, as it is no longer required. [1] [2] [3]AZURE_AI_SERVICE_LOCATIONfor specifying the Azure region for AI services (OpenAI/AI Foundry).AZURE_ENV_LOG_ANALYTICS_WORKSPACE_IDfor using an existing Log Analytics workspace.AZURE_EXISTING_AI_PROJECT_RESOURCE_IDfor using an existing AI Foundry project.Infrastructure parameter file simplification:
secondaryLocationandazureAiServiceLocationfrominfra/main.parameters.jsonandinfra/main.waf.parameters.jsonto match the updated documentation and streamline deployment parameters. [1] [2] [3] [4]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation