Add comprehensive Google-style docstrings to microsoft-agents-a365-notifications - #94
Merged
Johan Broberg (pontemonti) merged 6 commits intoFeb 6, 2026
Conversation
Jim Daly (JimDaly)
requested review from
Johan Broberg (pontemonti) and
Rahul Devikar (rahuldevikar761)
December 18, 2025 18:11
Co-authored-by: JimDaly <6353736+JimDaly@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update reference documentation for microsoft-agents-a365-notifications
Add comprehensive Google-style docstrings to microsoft-agents-a365-notifications
Dec 18, 2025
Jim Daly (JimDaly)
marked this pull request as ready for review
December 18, 2025 18:29
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive Google-style docstrings to the microsoft-agents-a365-notifications library to enable proper API documentation generation for learn.microsoft.com. The changes include detailed documentation for all public classes, methods, enums, and type aliases, along with code style improvements.
Key changes:
- Added Google-style docstrings with Args, Returns, Example, and Attributes sections to all public APIs
- Added copyright headers to model files
- Modernized type annotations from
Optional[X]toX | Nonesyntax
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Fixed import ordering to follow PEP 8 (stdlib imports alphabetically sorted) |
| models/wpx_comment.py | Added copyright header, class docstring, and modernized type annotations |
| models/notification_types.py | Added copyright header and comprehensive enum docstring with attribute descriptions |
| models/email_response.py | Added copyright header, class and method docstrings with examples |
| models/email_reference.py | Added copyright header, class docstring, and modernized type annotations |
| models/agent_subchannel.py | Added copyright header and enum docstring describing subchannel types |
| models/agent_notification_activity.py | Added copyright header, comprehensive class docstring with args/raises/example, property docstrings, and as_model method documentation |
| models/agent_lifecycle_event.py | Added copyright header and enum docstring describing lifecycle events |
| models/init.py | Added copyright header and module-level docstring |
| agent_notification.py | Added copyright header, comprehensive class docstring, type alias documentation, and detailed docstrings for all decorator methods with examples |
| init.py | Reordered imports alphabetically for consistency |
Rahul Devikar (rahuldevikar761)
previously approved these changes
Jan 6, 2026
Jim Daly (JimDaly)
requested changes
Jan 6, 2026
Co-authored-by: JimDaly <6353736+JimDaly@users.noreply.github.com>
Copilot
AI
dismissed
Rahul Devikar (rahuldevikar761)’s stale review
via
January 6, 2026 18:51
0c78adc
Rahul Devikar (rahuldevikar761)
requested changes
Jan 6, 2026
Rahul Devikar (rahuldevikar761)
left a comment
Collaborator
There was a problem hiding this comment.
Blocking the PR to review again
Johan Broberg (pontemonti)
requested a review
from Rahul Devikar (rahuldevikar761)
February 6, 2026 17:31
Johan Broberg (pontemonti)
approved these changes
Feb 6, 2026
Tahir Sousa (tmlsousa)
approved these changes
Feb 6, 2026
Johan Broberg (pontemonti)
enabled auto-merge (squash)
February 6, 2026 19:04
Rahul Devikar (rahuldevikar761)
approved these changes
Feb 6, 2026
Jim Daly (JimDaly)
approved these changes
Feb 6, 2026
Jim Daly (JimDaly)
left a comment
Member
There was a problem hiding this comment.
I can approve to the fact that these improved comments generated by Copilot are added.
I can't verify that they are correct. Looks like dev team members have reviewed this.
Johan Broberg (pontemonti)
deleted the
copilot/improve-reference-documentation
branch
February 6, 2026 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation Improvements for microsoft-agents-a365-notifications
agent_notification.pyAgentNotificationclass with detailed description and exampleson_email,on_word,on_excel,on_powerpoint, etc.)AgentHandlertype alias with comprehensive explanationagent_notification_activity.py- Document class, constructor, and all propertiesnotification_types.py- Document enum with descriptions for each valueagent_subchannel.py- Document enum with descriptions for each subchannelagent_lifecycle_event.py- Document enum with descriptions for each eventemail_reference.py- Document class and all fieldswpx_comment.py- Document class and all fieldsemail_response.py- Document class and static method with example__init__.pydocstringsOptional[X]toX | Nonetypeannotation instead of non-standardbuiltins.typeSummary
All files in the microsoft-agents-a365-notifications library now have comprehensive Google-style docstrings that will generate proper reference documentation on learn.microsoft.com. Fixed type annotation issue by replacing non-standard
builtins.typewith standardtypeannotation.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.