[O11y] Adds channel data to inference and tool scopes. - #89
Merged
Julio Carlos Menendez (juliomenendez) merged 4 commits intoDec 11, 2025
Merged
Conversation
Julio Carlos Menendez (juliomenendez)
requested a review
from a team
as a code owner
December 10, 2025 17:48
Copilot started reviewing on behalf of
Julio Carlos Menendez (juliomenendez)
December 10, 2025 17:48
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds channel data (source metadata) to inference and tool execution observability scopes. The changes enable tracking of execution source information (channel name and link/description) through OpenTelemetry span attributes, providing better context for agent operations.
Key Changes:
- Extended
InferenceScopeandExecuteToolScopeto capture and record source metadata from requests - Updated copyright headers in test files to follow the standard Microsoft format
- Added comprehensive tests to verify source metadata is correctly set on spans
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/observability/core/test_inference_scope.py | Updated copyright header and added test for source metadata on inference spans |
| tests/observability/core/test_execute_tool_scope.py | Added test for source metadata on tool execution spans |
| libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/inference_scope.py | Added source metadata capture logic to set channel attributes on spans |
| libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/execute_tool_scope.py | Added source metadata capture logic and request parameter support |
Copilot started reviewing on behalf of
Julio Carlos Menendez (juliomenendez)
December 10, 2025 19:06
View session
Julio Carlos Menendez (juliomenendez)
enabled auto-merge (squash)
December 10, 2025 20:34
Contributor
|
Any reason conversation Id is not included in this PR? |
PengF (fpfp100)
approved these changes
Dec 10, 2025
Johan Broberg (pontemonti)
approved these changes
Dec 11, 2025
Rahul Devikar (rahuldevikar761)
approved these changes
Dec 11, 2025
Nikhil Navakiran (nikhilNava)
approved these changes
Dec 11, 2025
Julio Carlos Menendez (juliomenendez)
deleted the
juliome/o11y-pass-channel-data-all-scopes
branch
December 11, 2025 23:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes assertions that were never running to validate data within the generated span.