Skip to content

Feature#1

Open
hassanShakur wants to merge 9 commits into
devfrom
feature
Open

Feature#1
hassanShakur wants to merge 9 commits into
devfrom
feature

Conversation

@hassanShakur
Copy link
Copy Markdown
Member

In this branch, I implemented the following requirements:

  • Create a new React app called 'hello-react-front-end'
  • Initialize your project with Git.
  • Create the App component with react-router.
  • Create the Greeting component that will display a greeting. Set it up as a route in your App component.
  • Create a store, an action and a reducer that will connect to you API endpont to get the random greeting.
  • Display the random greeting in your Greeting component.

Copy link
Copy Markdown

@t-yanick t-yanick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: CHANGES REQUIRED

Hi @hassanShakur ,

Good job so far!

To Highlight! 👏 🟢

✔️ App component with routes present
✔️ Store, an action, and a reducer that uses the url to the endpoint from the Rails API present
✔️ Backend repo present in ReadMe

There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

  • N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Comment thread README.md Outdated

## 📝 License <a name="license"></a>

This project is [MIT](MIT.md) licensed.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Great job working on this milestone and updating the ReadMe. Unfortunately, when I click on the MIT license link, it gives me an error 404 page. It is not professional to allow broken links in our codebase. Kindly fix this issue.

Screen Shot 2023-10-26 at 8 45 19 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants