Terrain factory implemented in WorldEnv's TerrainMixin - #36
Open
mbasel-t wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added terrain functionality to WorldEnv. With how defaults are implemented, current code using WorldEnv should not be bugged, as its functionality aside from terrain configs is untouched. I put the factory in gym/terrain/terrain.py because the code is too hefty to be put in a file in the mixins folder in my opinion.
I also created a short testing program that creates a simple Genesis simulation using WorldEnv, which should be kept in the repository because WorldEnv is an important part of the program which should be continually maintained, and because it serves as a reference for using WorldEnv to create a simple environment in future testing and training. The testing program is not complex at all, and one could definitely argue in-favor of a more complex test, but the test in its current state at least serves as a foundation for a more complex test to be created at a later date.