feat: add +10s seek forward button to admin control bar#499
Closed
Scribblerman wants to merge 2 commits intomholzi:mainfrom
Closed
feat: add +10s seek forward button to admin control bar#499Scribblerman wants to merge 2 commits intomholzi:mainfrom
Scribblerman wants to merge 2 commits intomholzi:mainfrom
Conversation
Add a seek forward button that lets the admin skip 10 seconds ahead during playback — useful for songs with long silent intros (especially via YouTube Music). Also adds tooltips and visible labels to all admin control bar buttons for better discoverability. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a seek forward feature to the media player, allowing admins to skip 10 seconds ahead during playback. The changes span the backend state management, websocket communication, and frontend UI, including localized tooltips and unit tests. A potential issue was identified in the websocket handler where the 'seconds' input is cast to a float without validation, which could lead to unhandled exceptions.
Address review feedback: wrap float() conversion in try-except to handle non-numeric input gracefully instead of crashing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
Duplicate of #511 (already merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Technical Details
MediaPlayerService.seek_forward()calculates actual position from HA's snapshot (media_position + elapsed since media_position_updated_at)seek_forwardallowed in PLAYING and REVEAL phasesCloses #498
Test plan
seek_forward()(correct position, defaults, error cases)🤖 Generated with Claude Code