fix: MA+YTMusic playback regression — restore timeout tolerance and add title verification (#345)

[Scribblerman]

Summary

Fixes a regression introduced by #418 that reverted the MA+YTMusic playback fix from #345.

• Timeout return value: [Code Review: bugs] Music Assistant playback always returns True masking failures #418 changed return True → return False on MA playback timeout, causing start_round() to retry with a new song. Since blocking=False, the previous song is still buffering — the Sonos receives 3-4 songs in rapid succession.
• Title verification: The polling loop only checked "did the title change?" but not "is it the correct song?". On retry, a late-arriving previous song was falsely confirmed as the new one (race condition).
• Next Round button: The "Next Round" button re-enabled after a hardcoded 2s timeout instead of waiting for the server's phase change, allowing premature clicks.
• WebSocket race condition: checkGameStatus() (async) and initAll() could both open a WebSocket simultaneously, causing InvalidStateError: Still in CONNECTING state and dropping the connection.

Changes

services/media_player.py

• Restore return True on timeout — MA+YTMusic can take >8s to buffer, don't skip the song
• Replace title_changed (any change) with title_matches (expected title substring, case-insensitive) to prevent race condition where a previous slow song is falsely confirmed

www/js/player-game.js

• Remove hardcoded setTimeout(2000) that re-enabled the Next Round button
• Export resetNextRoundPending() — called on actual phase change instead

www/js/player-core.js

• Import and call resetNextRoundPending() when phase transitions to PLAYING
• Add WebSocket guard in connectWithSession() and connectWebSocket() to prevent double connections

www/js/player.bundle.min.js

• Rebuilt via npx esbuild with above JS changes

tests/unit/test_media_player.py

• Restore test_ma_returns_true_even_on_timeout (was changed to assert False by [Code Review: bugs] Music Assistant playback always returns True masking failures #418)
• Add test_ma_ignores_wrong_song_from_previous_request — race condition regression test
• Add test_ma_matches_title_with_suffix — MA appends "(Official HD Video)" etc.

Test plan

• 278 unit tests passing (2 updated, 2 new)
• Tested live with MA + Sonos + YouTube Music
• Verified via HA logs: no more song switching, connections=1 on REVEAL broadcast
• Verified Next Round button stays disabled until server confirms phase change
• No diff between v2.9.1 and main for all changed files (except +10 unrelated lines in player-game.js)

🤖 Generated with Claude Code

[gemini-code-assist]

Code Review

This pull request improves the reliability of song playback confirmation in the media_player service by implementing case-insensitive substring matching for titles and preventing unnecessary retries during buffering. In the frontend, it adds guards against duplicate WebSocket connections and refactors the "Next Round" button logic to wait for server confirmation rather than using a fixed timeout. Review feedback highlights a potential AttributeError in the Python service if the song title is explicitly None and notes that the frontend resetNextRoundPending function needs to explicitly re-enable the UI button and reset its text to avoid it being stuck in a "Loading" state.

[Scribblerman]

Note: The two failing checks (Hassfest Validation, Lint) are pre-existing on main — see 2243a34. This PR does not introduce any new failures.

• Hassfest: extra keys not allowed @ data['platforms'] — from feat: expose game state as HA sensor and binary_sensor entities (closes #441) #476 (sensor entities)
• Lint: unused pytest import in test_round_manager.py — unrelated to this PR