Conversation
- Added support for static API keys in MCP authentication, allowing users to authenticate using hashed keys. - Updated the MCP connections schema to include keyHash, keyPrefix, and keyLastUsedAt fields. - Refactored the MCP authentication logic to handle API key authentication alongside OAuth JWT. - Improved error handling for revoked and unknown API keys. - Removed the development-only token minting endpoint for security reasons. - Enhanced the Preferences UI to manage API keys and provide connection instructions. - Updated tests to cover new API key functionality and ensure proper authentication flow.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| export function sha256Hex(value: string): string { | ||
| return createHash('sha256').update(value).digest('hex'); |
| --landing-shadow: | ||
| 0 1px 2px color-mix(in oklab, var(--foreground) 8%, transparent), | ||
| 0 16px 40px -20px color-mix(in oklab, var(--foreground) 28%, transparent); | ||
| color: var(--foreground); |
| background: color-mix(in oklab, var(--primary) 11%, transparent); | ||
| } | ||
|
|
||
| .landing-feature-icon svg { |
| opacity: 0; | ||
| transform: translateY(12px); | ||
| } | ||
| to { |
| opacity: 0; | ||
| transform: rotate(-1.4deg) translateY(12px); | ||
| } | ||
| to { |
| opacity: 0; | ||
| transform: rotate(0.9deg) translateX(0.9rem) translateY(12px); | ||
| } | ||
| to { |
There was a problem hiding this comment.
Csslint (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
Semgrep found 6
Bracket object notation with user input is present, this might allow an attacker to access all properties of the object and even it's prototype, leading to possible code execution. |
| } | ||
|
|
||
| const noAuth = await post(); | ||
| console.log(`no-token: ${noAuth}`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.