deps: bump HLab.Core to drop the dead CryptService - #543
Merged
Conversation
Picks up mgth/HLab.Core#6, which removes CryptService -- TripleDES with a hardcoded key and IV, referenced from nowhere in either repository. The smart-TV token encryption added alongside deliberately did not build on it. Pinned to 7c6ed67 rather than the master tip on purpose. That commit is the old pin plus the deletion and nothing else, and it is permanently reachable through the #6 merge. HLab.Core master has since moved six commits further -- a restored HLab.Mvvm.Application project, MessageBus and MvvmService changes, 447 insertions across 36 files -- and adopting that is a separate decision with its own testing, not something to smuggle in behind a one-file deletion. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up mgth/HLab.Core#6, which removes
CryptService— TripleDES with a hardcoded key and IV, referenced from nowhere in either repository. The smart-TV token encryption in #542 deliberately did not build on it.One line, one submodule pointer:
Why 7c6ed67 and not the master tip
7c6ed67is the old pin plus that deletion and nothing else, and it is permanently reachable through the #6 merge commit, so it does not depend on the PR branch surviving.HLab.Core
masterhas since moved six commits further:8b5f9c870cd5826f17c9004947791a5d56ae5b2388That is a restored
HLab.Mvvm.Applicationproject plusMessageBusandMvvmServicebehaviour changes — 447 insertions across 36 files. Adopting it is a separate decision with its own testing, not something to carry in behind a one-file deletion. Tracking the tip here would have done exactly that.Verification
dotnet build LittleBigMouse-Linux.slnfsucceeds withHLab.Core/CryptService.csactually absent from the working tree.Independent of #542 — disjoint files, both branch off
master, they merge in either order.🤖 Generated with Claude Code