oelint: Fix parsing of color enabled output

[offa]

If color is enabled through oelint configuration the parser wont match and no issues are reported.

Stripping the ANSI color sequences from the linter output addresses this.

[mfussenegger]

Would it be possible to instead override the config with some kind of argument/flag, or setting a NO_COLOR env variable?

[offa]

Unfortunately not. The CLI allows enable only and there are no env variables for config override.

[mfussenegger]

Any chance to bring this up upstream to have an option to force no-colors? I'd like to avoid having to deal with this in nvim-lint. Other editor integrations likely have the same problem.

See also http://no-color.org/

[offa]

NO_COLOR support was added in the new release 👍. I have reverted my initial approach and set NO_COLOR=1 instead.

While this works as expected when calling the parser manually, nvim-lint doesn't show any warnings. The env line sets NO_COLOR correctly, but it drops the other env vars. What’s the recommended approach here?

---

Update

Not touching anything at all, but just using master works now!? 🤔

[mfussenegger]

but it drops the other env vars.

That's currently sort of working as intended. It only preserves PATH if a linter has env set. Is that a problem?

Not touching anything at all, but just using master works now!?

That's odd, can you investigate more?

[offa]

That's currently sort of working as intended. It only preserves PATH if a linter has env set. Is that a problem?

I need to look into that more carefully; that's at least how it seems.

That's odd, can you investigate more?

Error on my end, configuration file wasn't picked up correctly.

[offa]

The missing HOME caused the linter to crash because it relies on it. A naive fix is to restore it that way. Is there a better solution?

[mfussenegger]

I'm considering to copy the current env by default if any linter.env variables are set. But for now this seems like a good solution