Skip to content

Fixes for #6 and #7 and also likely #19 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SirMrStep wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes for #6 and #7 and also likely #19 #25

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e905fc1
This removes any data from piston heads when they retract and therefo…
SirMrStep Nov 25, 2025
701946a
This will fix data not being removed from things like cactus, sugarca…
SirMrStep Nov 25, 2025
ad9752d
Noticed this old code was using the wrong event and that we don't see…
SirMrStep Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/com/jeff_media/customblockdata/BlockDataListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,14 @@ private void callAndRemove(Block block, Event bukkitEvent) {
public void onBreak(BlockBreakEvent event) {
callAndRemove(event);
}

@EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true)
public void onPhysics(BlockPhysicsEvent event) {
// event.getBlock().getType() returns air when the block is broken
if(event.getBlock().getType() == Material.AIR) {
callAndRemove(event.getBlock(), event);
}
}

@EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true)
public void onPlace(BlockPlaceEvent event) {
Expand Down Expand Up @@ -142,6 +150,10 @@ public void onPiston(BlockPistonExtendEvent event) {

@EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true)
public void onPiston(BlockPistonRetractEvent event) {
Block pistonHead = event.getBlock().getRelative(event.getDirection().getOppositeFace());
if(CustomBlockData.hasCustomBlockData(pistonHead, plugin)) {
callAndRemove(pistonHead);
}
onPiston(event.getBlocks(), event);
}

Expand Down