Prevent http.client.InvalidURL exception on set_article_url() - #6
Open
gbnegrini wants to merge 1 commit into
Open
Prevent http.client.InvalidURL exception on set_article_url()#6gbnegrini wants to merge 1 commit into
gbnegrini wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mfcovington!
I came across an uncaught "http.client.InvalidURL: URL can't contain control characters" exception while running pubmed-lookup on a project.
The issue was caused by a weird record['DOI'] string containing a whitespace (PMID: 31207675). The error can be reproduced running the code below:
I've added some split() and join() to set_article_url() method to remove whitespace characters from URLs. I don't think this is such a common issue, but I hope this change can help.