Conversation
Co-authored-by: mfa777 <2765931+mfa777@users.noreply.github.com> Agent-Logs-Url: https://github.com/mfa777/pg_with_backup/sessions/39bc7f3c-b7bf-424c-be40-a7e6c34eb84a
Co-authored-by: mfa777 <2765931+mfa777@users.noreply.github.com> Agent-Logs-Url: https://github.com/mfa777/pg_with_backup/sessions/39bc7f3c-b7bf-424c-be40-a7e6c34eb84a
Co-authored-by: mfa777 <2765931+mfa777@users.noreply.github.com> Agent-Logs-Url: https://github.com/mfa777/pg_with_backup/sessions/39bc7f3c-b7bf-424c-be40-a7e6c34eb84a
…r-tags Use release tags for Docker image publishing and add Docker skip markers
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the GitHub Actions release pipeline so Docker images are built/published from a reusable workflow using the generated semver release tag (instead of the commit SHA), with an opt-out mechanism via merge-commit markers.
Changes:
- Converted
build-and-push.ymlinto aworkflow_callreusable workflow that tags images with the generatedrelease_tagand can be skipped via a boolean input. - Updated the release workflow to detect
#skip-docker/:noimagein the merge commit message, conditionally invoke the reusable Docker workflow, and annotate release metadata with whether images were published or skipped. - Updated documentation to reflect the new release/tagging and Docker publishing flow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
docs/BUILD_AND_PUSH.md |
Documents the updated release-tag-based Docker publishing flow and skip markers. |
.github/workflows/release-on-master-merge.yml |
Adds skip-marker detection and calls the reusable build workflow; release notes reflect publish vs skip. |
.github/workflows/build-and-push.yml |
Reworked into a reusable workflow with inputs for release_tag, source_ref, and skip_docker; tags images using release_tag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the release and Docker image publishing workflows to make Docker builds more flexible and easier to control. The main improvements are the introduction of a reusable workflow for building and pushing Docker images, support for skipping Docker builds via commit message markers, and improved documentation describing the new process.
Workflow improvements and flexibility:
.github/workflows/build-and-push.ymlto be a reusable workflow that acceptsrelease_tag,source_ref, andskip_dockeras inputs, and usesrelease_tagfor Docker image tags instead of the commit SHA. It now conditionally runs based on theskip_dockerflag. [1] [2] [3]Conditional Docker publishing:
.github/workflows/release-on-master-merge.ymlto detect#skip-dockeror:noimagemarkers in the merge commit message and set theskip_dockeroutput accordingly, allowing releases to skip Docker image builds and pushes when needed. [1] [2]Documentation updates:
docs/BUILD_AND_PUSH.mdto describe the new workflow structure, the Docker skip mechanism, and how to customize or troubleshoot the release process. [1] [2]