Conversation
mf-sakura
reviewed
Mar 30, 2020
mf-sakura
left a comment
mf-sakura
left a comment
Owner
There was a problem hiding this comment.
@ookura-mf
コメントした所以外は良さそうに思います！
Comment on lines
+71
to
+72
| fmt.Fprint(w, fmt.Sprintf("Only POST method is permitted\n")) | ||
| return |
Owner
There was a problem hiding this comment.
これだと200ステータスで帰ってしまうので、squareHandler同様にステータス書き込みが必要です。
| fmt.Fprint(w, fmt.Sprintf("Value of Counter is %d \n", counter)) | ||
| } | ||
|
|
||
| func fizzbuzzHandler(w http.ResponseWriter, req *http.Request) { |
Owner
There was a problem hiding this comment.
fizzBuzzでcamelCaseにするか、固有名詞としてfizzbuzzにするか、どちらが良いんだろうかと思いました。
camelCaseを意識できているか気になってのコメントです。
把握はできていれば、後は好みなのでどちらでも良いと思います。
Author
There was a problem hiding this comment.
fizzbuzzで固有名詞のつもりでした 👀
javaとかswiftとか書いてたのでcamelCaseは割となじんでます（たまに忘れる・・・
ookura-mf
marked this pull request as ready for review
April 1, 2020 14:42
Owner
|
@ookura-mf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.