fix(drift): treat pipe-alternation shorthand as not a path - #221
Closed
dyk1454683243-sudo wants to merge 1 commit into
Closed
dyk1454683243-sudo wants to merge 1 commit into
dyk1454683243-sudo wants to merge 1 commit into
Conversation
isNotAPath already dropped globs with * / ? but still turned tests/grounding|traversal|edges|store.test.ts into a MISSING_PATH claim. Tokens with | are prose shorthand, not filesystem paths. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
This was referenced Sep 19, 2026
dyk1454683243-sudo
marked this pull request as ready for review
September 19, 2026 16:18
Author
|
Withdrawing this PR while I clean up a high-volume open-PR backlog. Sorry for the noise — happy to come back later with a focused change if useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Treat pipe-alternation shorthand such as
`tests/grounding|traversal|edges|store.test.ts`as not a filesystem path, so it never becomes a path claim orMISSING_PATH.isNotAPathalready dropped globs with*/?but not|. A token with|separating path segments or basenames is prose shorthand, not a file. Real paths without pipes stay claims: a missingtests/store.test.tsis stillMISSING_PATH.No fancy parser — the issue token is a single inline-code string containing
|.Why
Addresses #202 (bullet 4 only).
Do not treat this as
Fixes #202orCloses #202— that would auto-close the whole mega-issue.Remaining #202 bullets stay open:
src/auth/login.validateToken) — owned by fix(drift): treat qualified-name symbol notation as not a path #220.d.ts) — owned by fix(drift): treat compound extensions like .d.ts as not-paths #216./x,x.ts,x/index.ts) — owned by fix(drift): treat resolution stubs like ./x as not-paths #222@scope/pkg/package.jsonvs bare specifier) — owned by fix(drift): resolve scoped packages by bare specifier #217Type of change
How to test
npx vitest run src/drift`tests/grounding|traversal|edges|store.test.ts`produces zero path claims and zeroMISSING_PATHfor that token.tests/store.test.tsis still reported asMISSING_PATH.npm run typecheckChecklist
npx vitest run src/drift— 11 passed, 1 skipped#201version-shaped case left untouched)npm run typecheck)npm test) — full suite is not the gate for this one-filter changeCode-graph changes
mainLanguageExtractororFrameworkResolverinterfacecore / discuss-firstissue is linked aboveThis is a drift claim-extraction filter only. It does not change graph identity, extractors, or the other #202 bullets. Issue #202 stays open.